Use maven-failsafe-plugin to handle integration tests #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arteymix
commented
Feb 20, 2022
| <version>3.1.2</version> | ||
| <executions> | ||
| <execution> | ||
| <phase>process-resources</phase> |
There was a problem hiding this comment.
The pre-integration-test phase could be used for this, although it would be redundant if the model haven't been changed.
arteymix
commented
Feb 20, 2022
| <configuration> | ||
| <driver>com.mysql.cj.jdbc.Driver</driver> | ||
| <username>${gemma.db.build.user}</username> | ||
| <password>${gemma.db.build.password}</password> |
There was a problem hiding this comment.
It would be better to introduce gemma.testdb.user and gemma.testdb.password for this instead of reusing credentials.
arteymix
commented
Feb 20, 2022
| <goal>execute</goal> | ||
| </goals> | ||
| <configuration> | ||
| <url>${bootstrap.db.url}</url> |
There was a problem hiding this comment.
Here, a gemma.testdb.bootstrap-url might be a better choice.
arteymix
commented
Feb 20, 2022
| <goal>execute</goal> | ||
| </goals> | ||
| <configuration> | ||
| <url>${gemma.testdb.build.url}</url> |
There was a problem hiding this comment.
Replace this by gemma.testdb.url, simply.
arteymix
commented
Feb 20, 2022
| <configuration> | ||
| <argLine>-Dlog4j1.compatibility=true</argLine> | ||
| <includes> | ||
| <include>**/*Test.java</include> |
There was a problem hiding this comment.
Maybe add **/*IntegrationTest.java here as well?
arteymix
commented
Feb 20, 2022
| @@ -71,7 +71,8 @@ | |||
| /** | |||
| * Retrieve all {@link AnalysisResultSet} matching a set of criteria. | |||
| * | |||
| * @param datasets filter result sets that belong to any of the provided dataset identifiers, or null to ignore | |||
| * @param datasets filter result sets that belong to any of the provided dataset identifiers, or null to | |||
| * ignore | |||
arteymix
force-pushed
the
feature-use-failsafe-for-integration-tests
branch
2 times, most recently
from
9d0668b
to
03efc49
Compare
Only include tests marked by the UnitTest category for maven-sure-fire-plugin. Include all test ending with Test.java and exclude those marked by the UnitTest category for integration tests. Use integration-test and verify goals for maven-jasmin-plugin as it require a fake browser.
arteymix
force-pushed
the
feature-use-failsafe-for-integration-tests
branch
from
03efc49
to
740f871
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #293 for more details