support sync middleware initialization #50
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
idanto
suggested changes
Mar 11, 2019
| } | ||
|
|
||
| function init(swaggerPath, options) { |
There was a problem hiding this comment.
we should add comment that this is kept for backward compatibility and it's not really async
| @@ -52,6 +52,8 @@ | |||
| "dependencies": { | |||
| "ajv": "^6.6.2", | |||
| "clone-deep": "^4.0.1", | |||
| "js-yaml": "^3.12.2", | |||
| "json-schema-deref-sync": "^0.9.0", | |||
| "swagger-parser": "^6.0.2" | |||
There was a problem hiding this comment.
if you removed the dependency in swagger-parser please remove it from the dependencies as well
| }); | ||
| }); | ||
|
|
||
| describe.skip('And init fails', function () { |
|
I think that we should add it in api-schema-builder in order to avoid conflicts with #54 |
|
@kobik Do you need any help finishing this PR? |
|
@kobik @idanto Created PayU/api-schema-builder#20 based on implementation from this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #38