-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support sync middleware initialization #50
Conversation
1 similar comment
} | ||
|
||
function init(swaggerPath, options) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should add comment that this is kept for backward compatibility and it's not really async
@@ -52,6 +52,8 @@ | |||
"dependencies": { | |||
"ajv": "^6.6.2", | |||
"clone-deep": "^4.0.1", | |||
"js-yaml": "^3.12.2", | |||
"json-schema-deref-sync": "^0.9.0", | |||
"swagger-parser": "^6.0.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you removed the dependency in swagger-parser
please remove it from the dependencies as well
}); | ||
}); | ||
|
||
describe.skip('And init fails', function () { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why this is skipped?
I think that we should add it in api-schema-builder in order to avoid conflicts with #54 |
@kobik Do you need any help finishing this PR? |
@kobik @idanto Created PayU/api-schema-builder#20 based on implementation from this PR. |
closes #38