PHP 8.1 deprecations

[arokettu]

• Type hints are more strictly enforced but can be suppressed with #[\ReturnTypeWillChange]
• \Serializable is deprecated when used without __serialize / __unserialize: https://wiki.php.net/rfc/phase_out_serializable

[arokettu]

I addressed doctrine test crashes separately: #920

[arokettu]

I'm not sure what to do with this one:

1) Payum\Core\Tests\Security\SensitiveValueTest::shouldNotSerializeValue
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'N;'
+'O:34:"Payum\Core\Security\SensitiveValue":0:{}'

You can't serialize to null in 8.1+

[arokettu]

Rebased the PR. Serialization seems to be the only problem

[pierredup]

@arokettu I think you can wrap that test just in an if and check the expected value based on the PHP version

if (PHP_VERSION_ID >= 70400) {
    $this->assertEquals('O:34:"Payum\Core\Security\SensitiveValue":0:{}', $serializedValue);
} else {
    $this->assertEquals('N;', $serializedValue);
}

[arokettu]

@pierredup I'm more concerned whether it is not acceptable / acceptable but bc break / whatever other problem there might be

Fixing tests is easy

[pierredup]

@arokettu The SensitiveValue class is not supposed to be serializable, which is why there's a test to ensure this, and also why the serialize methods are added to block the value from being serialized.

IMHO if someone depends on this class being able to serialize to null, they are depending on undocumented behaviour that's not guaranteed, so I don't consider this change as a BC break.

[arokettu]

Ok, thank you

[arokettu]

Remaining deprecations:

  2x: utf8_encode(): Passing null to parameter #1 ($string) of type string is deprecated
    2x in GetAddressesActionTest::shouldCallKlarnaGetAddresses from Payum\Klarna\Invoice\Tests\Action\Api

  2x: utf8_decode(): Passing null to parameter #1 ($string) of type string is deprecated
    1x in PopulateKlarnaFromDetailsActionTest::shouldNotFaileIfEmptyDetailsGiven from Payum\Klarna\Invoice\Tests\Action\Api
    1x in PopulateKlarnaFromDetailsActionTest::shouldCorrectlyPutPartialArticles from Payum\Klarna\Invoice\Tests\Action\Api

  1x: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated
    1x in CaptureOffsiteActionTest::shouldRedirectToBe2billSiteIfExecCodeNotPresentInQuery from Payum\Be2Bill\Tests\Action

I couldn't trace the last one, may be an external one.

I don't know how to fix Klarna because I don't know what values it expects, I never used it. But anyway, Klarna's lib is not PHP 8.1 ready itself so the fix can be postponed.

[arokettu]

If that's ok I think it's ready. At least the Core is now PHP 8.1 ready

[pierredup]

Thank you @arokettu