-
-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doctrine compatibility fixes #920
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@arokettu Thanks for making these changes! I just have one comment on the json
types in the Doctrine config
@@ -2,7 +2,7 @@ | |||
<doctrine-mapping xmlns="http://doctrine-project.org/schemas/orm/doctrine-mapping" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://doctrine-project.org/schemas/orm/doctrine-mapping http://doctrine-project.org/schemas/orm/doctrine-mapping.xsd"> | |||
<mapped-superclass name="Payum\Core\Model\ArrayObject"> | |||
|
|||
<field name="details" column="details" type="json_array" /> | |||
<field name="details" column="details" type="json" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this might be a BC break since the json_array
and json
types handle the values from the DB differently. See #684 as well.
If this is indeed a BC break, then we should limit doctrine/dbal to < 3.0 for now and create a proper migration path
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeap, it is BC break
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reverted
@pierredup @makasim
|
Yes please
Yes all sub packages needs to be manually changed |
ok done |
anything else here? |
Thank you @arokettu |
This fixes test crashes introduced by the updated Doctrine libraries:
The first one only concerns tests, the second one updates orm mapping in Doctrine bridge