Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fix rector #990

Merged
merged 7 commits into from
Apr 1, 2024
Merged

feat: fix rector #990

merged 7 commits into from
Apr 1, 2024

Conversation

Chris53897
Copy link
Contributor

@Chris53897 Chris53897 commented Mar 9, 2024

fix rector-run for 1.7.x

PR to fix external Warnings
formapro/KlarnaInvoice#3

@Chris53897
Copy link
Contributor Author

@pierredup The CI run is fixed now.

But i disabled the auto-commit.
It will reintroduce Errors.
Actual it would make the following change.
That was fixed here https://github.com/Payum/Payum/pull/989/files#diff-4f756e454705bdf3e67c480b0ca47376ac62ed3964fa4e57c9444aa81ef073e1R119

          if (method_exists($this, 'expectExceptionMessageRegExp')) {
-            $this->expectExceptionMessageRegExp('/Given \"config_path\" is invalid. \w+/');
+            $this->expectExceptionMessageMatches('/Given \"config_path\" is invalid. \w+/');
         } else {
             $this->expectExceptionMessageMatches('/Given \"config_path\" is invalid. \w+/');
         }

@pierredup
Copy link
Member

@Chris53897 Thanks for the changes. I made a few changes to the PR:

  • Use the new DSL for Rector config
  • Skip the RenameMethodRector rector for the PaypalRestGatewayFactoryTest test class as to not re-introduce the changed line
  • Re-enable the auto-commit

@pierredup pierredup merged commit 858d981 into Payum:1.7.x Apr 1, 2024
10 checks passed
@Chris53897 Chris53897 deleted the feature/fix-rector branch April 1, 2024 15:13
@Chris53897
Copy link
Contributor Author

thanks @pierredup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants