Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add storages when constructing extension #548

Merged
merged 2 commits into from May 3, 2023
Merged

Conversation

pierredup
Copy link
Member

Add storage factories when constructing the container extension, to be compatible with Symfony's Config Builders. Without this change, the config builder doesn't recognise the storage configs.

@pierredup pierredup added the bug label May 3, 2023
@pierredup pierredup self-assigned this May 3, 2023
@what-the-diff
Copy link

what-the-diff bot commented May 3, 2023

PR Summary

  • Added constructor to PayumExtension class
    A new constructor has been added to improve the structure and organization of the class.
  • Refactored load() method
    Some code has been moved from the load() method to the new constructor, making the method cleaner and easier to maintain.

@pierredup pierredup merged commit 9e1765a into master May 3, 2023
20 checks passed
@pierredup pierredup deleted the sf-config-builders branch May 3, 2023 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant