Update 0.15 for Laravel 5.1 #22
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $this->package('payum/payum-laravel-package'); | ||
| \View::addNamespace('payum/payum', __DIR__.'/../../views'); | ||
|
|
||
| $this->app->error(function(ReplyInterface $reply) |
There was a problem hiding this comment.
I'd prefer this way, cuz you can easily customize response just by registering another listener
There was a problem hiding this comment.
never mind, I read you comments
This was referenced Jun 18, 2015
Closed
|
And the most important, This could not be merged to 0.15 because of BC breaks. Please rebase onto master |
Catch response of execute for conversion Update PayumServiceProvder.php for Laravel 5.1 HttpRedirect is a child of HttpResponse moved the reply conversion for HttpRedirect above HttpResponse so redirects are handled as intended
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the error handler that converted responses to a function on the controller since Laravel 5 does not support adding error handlers on App any longer
Updated controllers to use the conversion method.
Updated the ServiceProvider to use new Laravel 5 configuration