Update to Laravel 5.1 #24
Conversation
Catch response of execute for conversion Update PayumServiceProvder.php for Laravel 5.1 HttpRedirect is a child of HttpResponse moved the reply conversion for HttpRedirect above HttpResponse so redirects are handled as intended
That's ok to keep it simple, So let's keep it as it is now and see later |
@chaosfinity It would be great if you can do in a BC way. |
…Laravel version Added configuration option for controlling reply exceptions
|
The service provider now delegates to a version specific provider. To allow the v4 provider to throw reply exceptions and the v5 to convert the reply directly I did have to add a configuration option. I did not document the config option so the path can be changed if you dont like the "payum-laravel-package.settings.throwReplyExceptions" path. |
| "illuminate/support": "~4.0", | ||
| "illuminate/container": "~5.1", | ||
| "illuminate/routing": "~5.1", | ||
| "illuminate/support": "~5.1", |
There was a problem hiding this comment.
@chaosfinity could you change this to "~4.0|~5.1"?
Add laravel version 4 back to composer.json
|
Thanks. |
Rebase #22 to master
As far as continuing support for Laravel 4 I can work on that. It would be a provider that delegates to the correct provider based on version.
For your concern about being able to change the response by making a new event listener on Laravel 5 you can do that with middleware just watching for the response types that are returned by the controller. If developers still want to catch exceptions instead of using middleware to convert the response there could be a config option to throw exceptions as before. What do you think?