New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove base/utils/data/trait.dictionary.csv #1747
Comments
See also #729 |
Bump! I would like to see Here is the block of Here's a prototype of what a function that retrieves the priors for a given PFT might look like (from my current ED2 work). Pinging @robkooper @dlebauer @serbinsh as the function authors and @mdietze as benevolent overlord. |
Also, clean up and update documentation. Related to PecanProject#1747.
This issue is stale because it has been open 365 days with no activity. |
To fix this one (according to points by @infotroph) :
I suppose this has been fixed. If someone can please confirm on that (and point to the right direction). |
AFAIK this has not been addressed, as there are clearly many uses of
That said, I think the general agreement in recent years has been to try and reduce the extent to which pecan depends on the database, not increase it. I'm not sure what the best course of action is in this particular case. |
I'll re-raise Mike's 2017 suggestion that many of the existing uses could be removed by using the variable names as-is rather than trying to map them to prettier strings. A more ambitious approach would be to notice that the netCDF format encourages every variable to have a name, a long_name, and defined units; perhaps the PEcAn data standard should enforce that every model populates these in the output files and then our downstream code can look them up from there instead of the database. |
Yep it looks like, aside from the trait.lookup function itself all of the uses are for plotting |
Description
Context
As discussed in #1713
Possible Implementation
To remove trait.dictionary.csv, probably need to edit the following files (as determined by
$(grep -R 'trait.dictionary' pecan/)
:The text was updated successfully, but these errors were encountered: