Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove maintenance scripts that now live in bety #2563

Merged
merged 4 commits into from Apr 9, 2020

Conversation

infotroph
Copy link
Member

Description

Fixes #2314. Both scripts already exist in the bety project, so nothing to do on that end.

@robkooper @Chris-Schnaufer While we're at it, are there other scripts we should remove in this PR? update.mysql.sh and update.psql.sh look like possible candidates.

Motivation and Context

Review Time Estimate

  • Immediately
  • Within one week
  • When possible

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the CHANGELOG.md.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Member

@ashiklom ashiklom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm all about removing code. Let's do it more often!

Thanks for checking this.

@robkooper
Copy link
Member

Some scripts that can be removed:

  • check.dependencies.sh
  • install.dependencies.R (replaced by Makefile and generate_dependencies.R)
  • update.mysql.sh
  • update.psql.sh
  • dump.pgsql.sh
  • setversion.sh

Maybe delete:

  • install_deps.R

@infotroph
Copy link
Member Author

@robkooper looks like install_deps.R was part of the first round of Docker implementation. Is there a chance it'll be useful there in the future, or have you settled on a different approach?

@infotroph
Copy link
Member Author

On a few moments' further thought, I think install_deps.R can definitely go -- it comes close enough to doing the same thing the Makefile does using remotes::install_deps does that I don't see a need to maintain a separate implementation.

@mdietze mdietze merged commit eff6f0c into PecanProject:develop Apr 9, 2020
@infotroph infotroph deleted the 2314-scripts-to-bety branch April 14, 2020 20:41
@robkooper robkooper added this to the 1.8.0 milestone Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move BETYdb reindex and vacuum scripts to bety project
4 participants