Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XML Workflow submission API endpoint #2662

Merged
merged 10 commits into from Jul 27, 2020
Merged

XML Workflow submission API endpoint #2662

merged 10 commits into from Jul 27, 2020

Conversation

tezansahu
Copy link
Contributor

@tezansahu tezansahu commented Jul 22, 2020 •
edited

  • Created the endpoint for submitting a PEcAn Workflow in XML format
  • Modified the authentication filter to forward the userid to endpoints for use
  • Updated the tests, swagger API documentation & PEcAn book documentation

Review Time Estimate

  • Immediately
  • Within one week
  • When possible

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the CHANGELOG.md.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@tezansahu tezansahu self-assigned this Jul 22, 2020
@tezansahu tezansahu added the GSOC label Jul 22, 2020
mdietze
mdietze reviewed Jul 22, 2020
View reviewed changes
apps/api/R/submit.workflow.R Outdated Show resolved Hide resolved
tests/api.sipnet.xml Show resolved Hide resolved
tests/api.sipnet.xml Show resolved Hide resolved
tests/api.sipnet.xml Show resolved Hide resolved
@robkooper robkooper merged commit 33c4398 into PecanProject:develop Jul 27, 2020
@tezansahu
Copy link
Contributor Author

#2657 addressed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robkooper robkooper robkooper approved these changes

@mdietze mdietze mdietze left review comments

@ashiklom ashiklom Awaiting requested review from ashiklom

Assignees

@tezansahu tezansahu

Labels
GSOC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tezansahu @robkooper @mdietze