Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Integration Testing] PEcAn Docker Stack Run : Single Site, Single Model #3345

Open
wants to merge 32 commits into
base: develop
Choose a base branch
from
Open

[Integration Testing] PEcAn Docker Stack Run : Single Site, Single Model #3345

wants to merge 32 commits into from
+134 −0

Conversation

meetagrawal09
Copy link
Collaborator

Description

PR aims at adding a workflow for running a complete PEcAn workflow using PEcAn's docker stack.

Review Time Estimate

  • Immediately
  • Within one week
  • When possible

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • My name is in the list of CITATION.cff
  • I have updated the CHANGELOG.md.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@meetagrawal09 meetagrawal09 marked this pull request as draft July 27, 2024 17:48
infotroph
infotroph reviewed Jul 29, 2024
View reviewed changes
.github/workflows/model-run.yml Outdated Show resolved Hide resolved
.github/workflows/model-run.yml Outdated Show resolved Hide resolved
.github/workflows/model-run.yml Outdated Show resolved Hide resolved
.github/workflows/model-run.yml Outdated
Comment on lines 52 to 55
- name: Check if containers are running # This will be updated soon to a loop
run: |
docker ps
sleep 50
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see there exists a --wait option to docker compose up, but haven't used it myself. Would that be able to handle this step for us?

tests/test.xml Outdated Show resolved Hide resolved
Meet Agrawal added 2 commits August 1, 2024 22:01
infotroph
infotroph reviewed Aug 1, 2024
View reviewed changes
.github/workflows/model-run.yml Outdated Show resolved Hide resolved
.github/workflows/model-run.yml Outdated Show resolved Hide resolved
.github/workflows/model-run.yml Outdated Show resolved Hide resolved
.github/workflows/model-run.yml Outdated Show resolved Hide resolved
.github/workflows/model-run.yml Outdated Show resolved Hide resolved
.github/workflows/model-run.yml Outdated Show resolved Hide resolved
meetagrawal09 and others added 2 commits August 15, 2024 23:20
@meetagrawal09 @robkooper
Trying free-disk-space action
c78e999 
Co-authored-by: Rob Kooper <kooper@illinois.edu>
@meetagrawal09
typo
3c6d30a
@allgandalf allgandalf mentioned this pull request Aug 16, 2024
Closed
13 tasks
@meetagrawal09 meetagrawal09 marked this pull request as ready for review September 5, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infotroph infotroph infotroph left review comments

@robkooper robkooper robkooper left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
GitHub Actions Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@meetagrawal09 @infotroph @robkooper