Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Autosaver] Remove effect with connections breaks #53

Closed
SrMouraSilva opened this issue Jun 12, 2017 · 0 comments
Closed

[Autosaver] Remove effect with connections breaks #53

SrMouraSilva opened this issue Jun 12, 2017 · 0 comments

Comments

@SrMouraSilva
Copy link
Member

SrMouraSilva commented Jun 12, 2017

How:

  • Add a effect
  • Add TWO connections for this effect
  • Remove effect

How to work around the problem:

  • Remove one connection
  • Remove effect
Traceback (most recent call last):
  File "/home/pi/.local/lib/python3.4/site-packages/webservice/util/handler_utils.py", line 58, in wrapped
    f(*args, **kwargs)
  File "/home/pi/.local/lib/python3.4/site-packages/webservice/util/handler_utils.py", line 58, in wrapped
    f(*args, **kwargs)
  File "/home/pi/.local/lib/python3.4/site-packages/webservice/util/handler_utils.py", line 30, in wrapped
    f(*args, **kwargs)
  File "/home/pi/.local/lib/python3.4/site-packages/webservice/handler/effect_handler.py", line 59, in delete
    del pedalboard.effects[effect_index]
  File "/home/pi/.local/lib/python3.4/site-packages/pluginsmanager/observer/observable_list.py", line 135, in __delitem__
    self.observer(UpdateType.DELETED, item, sliced)
  File "/home/pi/.local/lib/python3.4/site-packages/pluginsmanager/model/pedalboard.py", line 103, in _effects_observer
    self._clear_effect(effect)
  File "/home/pi/.local/lib/python3.4/site-packages/pluginsmanager/model/pedalboard.py", line 113, in _clear_effect
    self.connections.remove(connection)
  File "/home/pi/.local/lib/python3.4/site-packages/pluginsmanager/observer/observable_list.py", line 63, in remove
    self.observer(UpdateType.DELETED, item, index)
  File "/home/pi/.local/lib/python3.4/site-packages/pluginsmanager/model/pedalboard.py", line 119, in _connections_observer
    self.observer.on_connection_updated(connection, update_type, pedalboard=self, **kwargs)
  File "/home/pi/.local/lib/python3.4/site-packages/pluginsmanager/observer/observer_manager.py", line 77, in on_connection_updated
    observer.on_connection_updated(connection, update_type, pedalboard=pedalboard, **kwargs)
  File "/home/pi/.local/lib/python3.4/site-packages/pluginsmanager/observer/autosaver/autosaver.py", line 165, in on_connection_updated
    self.banks_files.save_bank(pedalboard.bank)
  File "/home/pi/.local/lib/python3.4/site-packages/pluginsmanager/observer/autosaver/banks_files.py", line 60, in save_bank
    Persistence.save(path, bank.json)
  File "/home/pi/.local/lib/python3.4/site-packages/pluginsmanager/model/bank.py", line 121, in json
    return self.__dict__
  File "/home/pi/.local/lib/python3.4/site-packages/pluginsmanager/model/bank.py", line 133, in __dict__
    'pedalboards': [pedalboard.json for pedalboard in self.pedalboards]
  File "/home/pi/.local/lib/python3.4/site-packages/pluginsmanager/model/bank.py", line 133, in <listcomp>
    'pedalboards': [pedalboard.json for pedalboard in self.pedalboards]
  File "/home/pi/.local/lib/python3.4/site-packages/pluginsmanager/model/pedalboard.py", line 128, in json
    return self.__dict__
  File "/home/pi/.local/lib/python3.4/site-packages/pluginsmanager/model/pedalboard.py", line 135, in __dict__
    'connections': [connection.json for connection in self.connections],
  File "/home/pi/.local/lib/python3.4/site-packages/pluginsmanager/model/pedalboard.py", line 135, in <listcomp>
    'connections': [connection.json for connection in self.connections],
  File "/home/pi/.local/lib/python3.4/site-packages/pluginsmanager/model/connection.py", line 97, in json
    return self.__dict__
  File "/home/pi/.local/lib/python3.4/site-packages/pluginsmanager/model/connection.py", line 102, in __dict__
    'output': self.output.json,
  File "/home/pi/.local/lib/python3.4/site-packages/pluginsmanager/model/output.py", line 137, in json
    return self.__dict__
  File "/home/pi/.local/lib/python3.4/site-packages/pluginsmanager/model/lv2/lv2_output.py", line 50, in __dict__
    dictionary = super(Lv2Output, self).__dict__
  File "/home/pi/.local/lib/python3.4/site-packages/pluginsmanager/model/output.py", line 142, in __dict__
    'effect': self.effect.index,
  File "/home/pi/.local/lib/python3.4/site-packages/pluginsmanager/model/effect.py", line 150, in index
    return self.pedalboard.effects.index(self)
  File "/home/pi/.local/lib/python3.4/site-packages/pluginsmanager/observer/observable_list.py", line 69, in index
    return self._list.index(x)
ValueError: <Lv2Effect object as 'Calf Saturator' not active at 0x75d9fb50> is not in list
@SrMouraSilva SrMouraSilva added this to the v0.5.1 milestone Jun 12, 2017
@SrMouraSilva SrMouraSilva changed the title Autosaver - Remove effect with connections breaks [Autosaver] Remove effect with connections breaks Jun 12, 2017
SrMouraSilva added a commit that referenced this issue Jun 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant