Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#68 remove connections too #73

Merged
merged 4 commits into from Oct 19, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGES
Expand Up @@ -21,10 +21,13 @@ Version 0.6.0 -- released 10/?/17
- Fixed Changelog: Now is possible see it in the documentation;
- `Issue #38`_ - Raise erros then add sys_effect in any Pedalboard;
- `Issue #65`_ - Fix documentation bug `SystemEffectBuilder(client).build()` instead `SystemEffectBuilder(client)`;
- `Issue #68`_ - Remove current mod-host pedalboard don't removes systems connection (system.output to system.input);

.. _Issue #38: https://github.com/PedalPi/PluginsManager/issues/38
.. _Issue #57: https://github.com/PedalPi/PluginsManager/issues/57
.. _Issue #65: https://github.com/PedalPi/PluginsManager/issues/65
.. _Issue #67: https://github.com/PedalPi/PluginsManager/issues/67
.. _Issue #68: https://github.com/PedalPi/PluginsManager/issues/68

Version 0.5.1 -- released 08/16/17
**********************************
Expand Down
91 changes: 51 additions & 40 deletions makefile
@@ -1,63 +1,74 @@
.RECIPEPREFIX +=
BROWSER=firefox
BOLD=\033[1m
NORMAL=\033[0m

default: run
default: help

clean: clean-pyc clean-test clean-build
clean: clean-pyc clean-test clean-build clean-docs

clean-build:
rm -rf .eggs
rm -rf build
rm -rf dist
rm -rf .eggs
rm -rf build
rm -rf dist

clean-pyc:
find . -name '*.pyc' -exec rm --force {} +
find . -name '*.pyo' -exec rm --force {} +
find . -name '*.pyc' -exec rm --force {} +
find . -name '*.pyo' -exec rm --force {} +

clean-test:
rm -f .coverage
rm -rf htmlcov
rm -rf test/autosaver_data
rm -rf .cache
rm -f .coverage
rm -rf htmlcov
rm -rf test/autosaver_data

clean-docs:
rm -rf docs/build
rm -rf docs/build

docs: clean-docs
cd docs && $(MAKE) html
cd docs && $(MAKE) html

docs-see: docs
$(BROWSER) docs/build/html/index.html
$(BROWSER) docs/build/html/index.html

install-tests-requirements:
# For midi tests - https://github.com/x42/midifilter.lv2
cd /tmp && git clone git://github.com/x42/midifilter.lv2.git && \
cd midifilter.lv2 && \
make && \
sudo make install PREFIX=/usr
# For midi tests - https://github.com/x42/midifilter.lv2
cd /tmp && git clone git://github.com/x42/midifilter.lv2.git && \
cd midifilter.lv2 && \
make && \
sudo make install PREFIX=/usr

run:
@echo "Run option isn't created =)"
@echo "Run option isn't created =)"

test: clean-test
mkdir test/autosaver_data
coverage3 run --source=pluginsmanager setup.py test
coverage3 report
mkdir test/autosaver_data
pytest --cov=pluginsmanager

test-details: test
coverage3 html
$(BROWSER) htmlcov/index.html

help:
@echo " clean"
@echo " Clean files"
@echo " docs"
@echo " Make the docs"
@echo " docs-see"
@echo " Make the docs and open it in BROWSER"
@echo " test"
@echo " Execute the tests"
@echo " test-details"
@echo " Execute the tests and shows the result in BROWSER"
@echo " - BROWSER=firefox"
@echo " help"
@echo " Show the valid commands"
coverage3 html
$(BROWSER) htmlcov/index.html

help: cabecalho
@echo ""
@echo "Commands"
@echo " $(BOLD)clean$(NORMAL)"
@echo " Clean files"
@echo " $(BOLD)docs$(NORMAL)"
@echo " Make the docs"
@echo " $(BOLD)docs-see$(NORMAL)"
@echo " Make the docs and open it in BROWSER"
@echo " $(BOLD)test$(NORMAL)"
@echo " Execute the tests"
@echo " $(BOLD)test-details$(NORMAL)"
@echo " Execute the tests and shows the result in BROWSER"
@echo " - BROWSER=firefox"
@echo " $(BOLD)help$(NORMAL)"
@echo " Show the valid commands"

cabecalho:
@echo "$(BOLD) _____ _ _ _____"
@echo "| _ || | _ _ ___ |_| ___ ___ | | ___ ___ ___ ___ ___ ___"
@echo "| __|| || | || . || || ||_ -|| | | || .'|| || .'|| . || -_|| _|"
@echo "|__| |_||___||_ ||_||_|_||___||_|_|_||__,||_|_||__,||_ ||___||_|"
@echo " |___| |___|"
@echo "Github$(NORMAL): https://pypi.org/project/PedalPi-PluginsManager/"
1 change: 1 addition & 0 deletions pluginsmanager/observer/mod_host/mod_host.py
Expand Up @@ -292,6 +292,7 @@ def _change_pedalboard(self, pedalboard):

def _remove_pedalboard(self, pedalboard):
self._remove_effects(pedalboard.effects)
self._remove_connections_of(pedalboard)

def _remove_connections_of(self, pedalboard):
for connection in pedalboard.connections:
Expand Down