Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update dependencies #687

Merged
merged 1 commit into from
Nov 20, 2023
Merged

chore: update dependencies #687

merged 1 commit into from
Nov 20, 2023

Conversation

serprex
Copy link
Contributor

@serprex serprex commented Nov 20, 2023

Also: combine COPY/RUN commands in dockerfiles where applicable. Reduces size of images by reducing layers

Hold back gosnowflake/aws-sdk-go, gosnowflake changed default PUT to ovewrite=false in 1.7.0 & aws-sdk-go has breaking changes in aws-sdk-go 1.48
https://docs.snowflake.com/en/release-notes/clients-drivers/golang-2023

snowflakedb/gosnowflake#971
aws/aws-sdk-go-v2#2162

@heavycrystal
Copy link
Contributor

we use PUT to load Avro files to Snowflake stages, will this library change impact that?

@serprex
Copy link
Contributor Author

serprex commented Nov 20, 2023

@heavycrystal probably. reverted 1.7 for other reasons too. might make 1.7 update its own PR later this week

Also: combine COPY/RUN commands in dockerfiles where applicable

Hold back gosnowflake/aws-sdk-go, gosnowflake changed default PUT to ovewrite=false in 1.7.0 & aws-sdk-go has breaking changes in aws-sdk-go 1.48
https://docs.snowflake.com/en/release-notes/clients-drivers/golang-2023
@heavycrystal
Copy link
Contributor

add to the PR description why the COPY/RUN coalescing was done, for performance/readability or otherwise

@serprex serprex merged commit b65913f into main Nov 20, 2023
12 checks passed
iskakaushik added a commit that referenced this pull request Nov 21, 2023
iskakaushik added a commit that referenced this pull request Nov 21, 2023
This reverts commit b65913f.

peerdb-server was crashing with this. reverting first to investigate.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants