Don't create metadata schema in a transaction #943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iskakaushik
reviewed
Dec 30, 2023
When a command errors during a transaction the transaction can no longer progress, it must be rolled back. This is the case when IF NOT EXISTS errors over unique violation We do not need schema/table creation to be transactional, so remove transaction
serprex
force-pushed
the
remove-transactional-metadata-schema-setup
branch
from
c73dbe9
to
ad9953f
Compare
|
#941 is now passing when rebased onto this PR |
iskakaushik
approved these changes
Dec 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a command errors during a transaction the transaction can no longer progress, it must be rolled back. This is the case when IF NOT EXISTS errors over unique violation
We do not need schema/table creation to be transactional, so remove transaction
Corrects #942 & #905 to be effective