Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split userpublickey #156

Merged
merged 7 commits into from
Jan 8, 2017
Merged

Split userpublickey #156

merged 7 commits into from
Jan 8, 2017

Conversation

ianopolous
Copy link
Member

Move boxing key from UserPublicKey WriterData. This means it is now automatically authenticated by the signing key.

… to Cbor serialization. Made key pair no longer a subtype of public key. This will make it harder to accidentally send a private key over the wire/
@ianopolous
Copy link
Member Author

Locations now cannot include private keys. A separate SigningKeyPair must be explicitly present to commit a write.

Copy link
Member

@cboddy cboddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@cboddy cboddy merged commit 8011fbb into master Jan 8, 2017
@ianopolous ianopolous deleted the split_userpublickey branch January 25, 2017 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants