Add progress bar for multi-select move and copy actions. #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianopolous
reviewed
Mar 28, 2024
| @@ -2339,9 +2351,29 @@ module.exports = { | |||
| } | |||
| this.closePasteMenu(); | |||
| that.showSpinner = true; | |||
There was a problem hiding this comment.
Can we drop the spinner if we have a progress bar?
There was a problem hiding this comment.
No. Spinner is a modal. This stops other actions until completion. We want that behaviour
There was a problem hiding this comment.
Why? We don't have a spinner during uploads.
There was a problem hiding this comment.
i'm not comfortable changing the behaviour without significant testing. This PR is about adding notification to the user as copy/move is progressing.
There was a problem hiding this comment.
Is there anywhere else where we show spinner and progress bar at the same time?
I don't think this is different from uploading files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.