Skip to content
This repository has been archived by the owner on Sep 26, 2019. It is now read-only.

PIE-1781: Enforce nonce validation on PrivateTransactionProcessor #1713

Merged
merged 2 commits into from
Jul 18, 2019
Merged

PIE-1781: Enforce nonce validation on PrivateTransactionProcessor #1713

merged 2 commits into from
Jul 18, 2019

Conversation

lucassaldanha
Copy link
Contributor

  • Created PrivateTransactionValidator to unify logic from PrivateTransactionHandler#validateTransaction and PrivateTransactionProcessor

iikirilov
iikirilov approved these changes Jul 17, 2019
View reviewed changes
Copy link
Contributor

@iikirilov iikirilov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Feel free to disregard the suggestion if you feel it is out of scope.

...m/core/src/main/java/tech/pegasys/pantheon/ethereum/privacy/PrivateTransactionValidator.java Show resolved Hide resolved
@lucassaldanha lucassaldanha merged commit 133dc28 into PegaSysEng:master Jul 18, 2019
@lucassaldanha lucassaldanha deleted the PIE-1781 branch July 18, 2019 01:28
lucassaldanha added a commit to lucassaldanha/pantheon that referenced this pull request Jul 24, 2019
@lucassaldanha
PIE-1781: Enforce nonce validation on PrivateTransactionProcessor (Pe…
67d44ee 
…gaSysEng#1713)
lucassaldanha added a commit that referenced this pull request Jul 25, 2019
@lucassaldanha
[PIE-1792 & PIE-1781] Fix private tx signature validation (#1753)
b315fef 
* PIE-1781: Enforce nonce validation on PrivateTransactionProcessor (#1713)

* PIE-1792: Added chainId validation to PrivateTransactionValidator (#1741)

* PIE-1792: Added chainId validation to PrivateTransactionValidator
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@usmansaleem usmansaleem usmansaleem approved these changes

@macfarla macfarla macfarla approved these changes

@Puneetha17 Puneetha17 Puneetha17 approved these changes

@iikirilov iikirilov iikirilov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lucassaldanha @usmansaleem @macfarla @Puneetha17 @iikirilov