Skip to content
This repository has been archived by the owner on Sep 26, 2019. It is now read-only.

Treat discovery peer with unknown endpoint as unknown #1942

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mbaxter
Copy link
Contributor

@mbaxter mbaxter commented Sep 13, 2019

PR description

Update discovery logic to consider a peer with an unknown discovery endpoint to be unknown regardless of whether we've encountered a peer with the same node id before. This makes the discovery logic more forgiving in the face of node restarts.

If nodeA bonds with nodeB, then nodeB crashes and restarts with a different ip address or listening port, nodeA would previously continue trying to communicate with nodeB at its original address. With these changes, nodeA will now treat the resurrected nodeB as a new peer and communicate with it on its updated endpoint.

Opening this as a draft PR to get input on whether people think this is a good idea.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant