This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 130
Default node key location should always be under data dir #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n when not using the default data dir.
NicolasMassart
approved these changes
Nov 15, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, sorry for the issue, I forgot the default value was not updated after parsing the command...
smatthewenglish
pushed a commit
to smatthewenglish/pantheon
that referenced
this pull request
Nov 15, 2018
…n when not using the default data dir. (PegaSysEng#265)
smatthewenglish
pushed a commit
to smatthewenglish/pantheon
that referenced
this pull request
Nov 15, 2018
…n when not using the default data dir. (PegaSysEng#265)
smatthewenglish
pushed a commit
to smatthewenglish/pantheon
that referenced
this pull request
Nov 15, 2018
…n when not using the default data dir. (PegaSysEng#265)
smatthewenglish
pushed a commit
to smatthewenglish/pantheon
that referenced
this pull request
Nov 15, 2018
…n when not using the default data dir. (PegaSysEng#265)
smatthewenglish
pushed a commit
to smatthewenglish/pantheon
that referenced
this pull request
Nov 15, 2018
…n when not using the default data dir. (PegaSysEng#265)
smatthewenglish
pushed a commit
to smatthewenglish/pantheon
that referenced
this pull request
Nov 15, 2018
…n when not using the default data dir. (PegaSysEng#265)
smatthewenglish
pushed a commit
to smatthewenglish/pantheon
that referenced
this pull request
Nov 15, 2018
…n when not using the default data dir. (PegaSysEng#265)
smatthewenglish
pushed a commit
to smatthewenglish/pantheon
that referenced
this pull request
Nov 15, 2018
…n when not using the default data dir. (PegaSysEng#265)
smatthewenglish
pushed a commit
to smatthewenglish/pantheon
that referenced
this pull request
Nov 15, 2018
…n when not using the default data dir. (PegaSysEng#265)
smatthewenglish
pushed a commit
to smatthewenglish/pantheon
that referenced
this pull request
Nov 15, 2018
…n when not using the default data dir. (PegaSysEng#265)
smatthewenglish
pushed a commit
to smatthewenglish/pantheon
that referenced
this pull request
Nov 22, 2018
…n when not using the default data dir. (PegaSysEng#265)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
When a custom data directory was specified, the default node private key file was still relative to the default data directory but should have been under the custom one.