This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Use consistent ports for quickstart #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…we get consistent ports to bind to.
NicolasMassart
suggested changes
Oct 16, 2018
…dd_demo_options_to_docker_run_quickstart
…_to_docker_run_quickstart' into feature/NC-1738_add_demo_options_to_docker_run_quickstart
…tions_to_docker_run_quickstart add options for fixed ports and skip build
NicolasMassart
approved these changes
Oct 17, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
Description
Specify the outbound host port for the ports command in the quickstart docker compose file so we get consistent ports to bind to.
Motivation and Context
Makes testing and using the images much better and easier.
Types of changes