Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some additional metrics to CSV output #12

Merged
merged 3 commits into from
May 21, 2021
Merged

Add some additional metrics to CSV output #12

merged 3 commits into from
May 21, 2021

Conversation

michaelclarkcuadrado
Copy link
Contributor

Hello!

At your discretion and convenience please merge the following changes:

  • Bump version to 0.5.
  • Add log's filename, unique plot ID, and per-phase/total CPU utilization to CSV output.
  • Default to only providing tmpdir1, or if tmpdir2 exists, tmpdir2.

Two tmpdirs are rarely used in practice and are only recommended for phase 1/2 in ramdisk, which is unlikely on contemporary hardware (200+ GB of ram necessary per plot).

@Pengor
Copy link
Owner

Pengor commented May 14, 2021

Thanks for the PR, I'll look this over and likely merge next week, I'm away from my PC this weekend 🌞

@Pengor Pengor self-assigned this May 14, 2021
@Pengor Pengor added the enhancement New feature or request label May 14, 2021
Copy link
Owner

@Pengor Pengor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are acceptable if the following are addressed:

  • Add back Temp dir 1 & Temp dir 2 (not everyone will use both but some might and it's simple to remove a column of data from the final .csv file if you don't care about it).
  • Filename (in main.cpp) and Log Filename (in README.md) headings should have the same name for consistency (I would prefer Log filename for consistency with case used by other headings).

Thanks!

@Pengor Pengor linked an issue May 19, 2021 that may be closed by this pull request
This was referenced May 19, 2021
@Pengor Pengor merged commit 6353dd3 into Pengor:main May 21, 2021
@Pengor
Copy link
Owner

Pengor commented May 21, 2021

Finished the requested changes out myself, thanks for helping improve the project @michaelclarkcuadrado!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add cpu percentage
2 participants