Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update_match/update_games/delete_match doesn't update wins/losses on deck_cache? #5562

Closed
vorpal-buildbot opened this issue Oct 16, 2018 · 3 comments · Fixed by #6707
Closed

update_match/update_games/delete_match doesn't update wins/losses on deck_cache? #5562

vorpal-buildbot opened this issue Oct 16, 2018 · 3 comments · Fixed by #6707
Labels
+ bug * decks pennydreadfulmagic.com (but use more specific label if available)

Comments

@vorpal-buildbot
Copy link
Contributor

Reported on Discord by bakert#2193
@triage-new-issues triage-new-issues bot added the triage Used by bot to label unlabeled tasks, will be removed automatically upon labeling label Oct 16, 2018
@bakert bakert changed the title update_match/update_games doesn't update wins/losses on deck_cache? update_match/update_games/delete_match doesn't update wins/losses on deck_cache? Oct 16, 2018
@bakert bakert added + bug * decks pennydreadfulmagic.com (but use more specific label if available) labels Oct 16, 2018
@triage-new-issues triage-new-issues bot removed the triage Used by bot to label unlabeled tasks, will be removed automatically upon labeling label Oct 16, 2018
@bakert
Copy link
Member

bakert commented Oct 16, 2018 •
edited

This is rare enough and on admin time only that we could just fire off a complete update of wins/draws/omw even though it's overkill just to avoid having extra code.

@bakert
Copy link
Member

bakert commented Nov 5, 2019

Ahhhhh! This is going to be the cause of #6647

@bakert
Copy link
Member

bakert commented Nov 5, 2019

c8e2b1a.

@bakert bakert closed this as completed Nov 5, 2019
bakert added a commit that referenced this issue Nov 5, 2019
@bakert
Keep deck_cache.{wins,losses,draws} up to date after admin actions.
c8e2b1a 
Fixes #5562.
Fixes #6647.
@bakert bakert mentioned this issue Nov 5, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
+ bug * decks pennydreadfulmagic.com (but use more specific label if available)
Projects
None yet
Milestone
No milestone
2 participants
@bakert @vorpal-buildbot