Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build system] Allow the runtime to be compiled on macOS in parallel and using ld64. #232

Merged
merged 4 commits into from
Aug 9, 2023

Conversation

erick-xanadu
Copy link
Contributor

Context: macOS lacks nproc and uses a different loader.

Description of the Change: Determine how many processors are available on an Apple machine via sysctl) to replace nproc. Use an -all_load instead of --whole-archive.

Benefits: Improved portability, we can compile the runtime on macOS.

Copy link
Member

@mlxd mlxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a fly-by comment

runtime/Makefile Outdated Show resolved Hide resolved
@erick-xanadu erick-xanadu marked this pull request as ready for review August 9, 2023 18:06
@erick-xanadu erick-xanadu merged commit 4e3e108 into main Aug 9, 2023
21 checks passed
@erick-xanadu erick-xanadu deleted the eochoa/2023-08-09/makefile-macos branch August 9, 2023 18:15
@maliasadi
Copy link
Member

[sc-43392]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants