Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update various tags/pins following the PennyLane v0.33 release #345

Merged
merged 8 commits into from
Oct 31, 2023
Merged

Update various tags/pins following the PennyLane v0.33 release #345

merged 8 commits into from
Oct 31, 2023

Conversation

dime10
Copy link
Collaborator

@dime10 dime10 commented Oct 31, 2023 •
edited
Loading

@dime10 dime10 requested a review from rmoyard October 31, 2023 17:57
rmoyard
rmoyard approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@rmoyard rmoyard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dime10, it looks good to me!

maliasadi
maliasadi approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@maliasadi maliasadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@dime10 dime10 requested a review from maliasadi October 31, 2023 20:05
maliasadi
maliasadi approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@maliasadi maliasadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dime10! There are just codefactor warnings required some fixes.

mlir/python/QuantumExtension.cpp Show resolved Hide resolved
@dime10
Copy link
Collaborator Author

dime10 commented Oct 31, 2023

There are just codefactor warnings required some fixes.

The errors don't make much sense in these files. I tried to make codefactor ignore them with the pylintrc file, but they should already be ignored.

We can merge as is I think.

@dime10 dime10 merged commit 4148a81 into main Oct 31, 2023
17 of 18 checks passed
@dime10 dime10 deleted the pl-rel-upgrade branch October 31, 2023 21:10
@maliasadi maliasadi mentioned this pull request Oct 31, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maliasadi maliasadi maliasadi approved these changes

@rmoyard rmoyard rmoyard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dime10 @maliasadi @rmoyard