Stop enabling and disabling new_opmath #845
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
In
test_measurements_results.py
, we explicitly enable and then disablenew_opmath
inside each test. Enablingnew_opmath
is no longer necessary, because it's the default. Disabling it at the end of each test means that when the test is completed, we are set to use legacyopmath
.Locally we run each test file separately, but in CI, any tests on the same runner that are run after this file are run with new_opmath disabled. This can lead to discrepancies between local and CI testing.
Description of the Change:
We remove the explicit enabling and disabling of
new_opmath
Benefits:
We will be testing everything with new opmath in CI as intended, and local and CI tests will correspond better to each other.
Possible Drawbacks:
This came up in a couple of PRs because added functionality failed with legacy opmath (otherwise this would never have been visible). Without this, we wouldn't have caught the legacy opmath incompatibility. But if we want to check for incompatibility with legacy opmath, we should add a workflow to the test matrix checking the whole thing regularly.