Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop enabling and disabling new_opmath #845

Merged
merged 3 commits into from
Jun 21, 2024
Merged

Conversation

lillian542
Copy link
Contributor

Context:

In test_measurements_results.py, we explicitly enable and then disable new_opmath inside each test. Enabling new_opmath is no longer necessary, because it's the default. Disabling it at the end of each test means that when the test is completed, we are set to use legacy opmath.

Locally we run each test file separately, but in CI, any tests on the same runner that are run after this file are run with new_opmath disabled. This can lead to discrepancies between local and CI testing.

Description of the Change:
We remove the explicit enabling and disabling of new_opmath

Benefits:
We will be testing everything with new opmath in CI as intended, and local and CI tests will correspond better to each other.

Possible Drawbacks:
This came up in a couple of PRs because added functionality failed with legacy opmath (otherwise this would never have been visible). Without this, we wouldn't have caught the legacy opmath incompatibility. But if we want to check for incompatibility with legacy opmath, we should add a workflow to the test matrix checking the whole thing regularly.

Copy link

codecov bot commented Jun 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.98%. Comparing base (8c191be) to head (764059b).
Report is 200 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #845      +/-   ##
==========================================
- Coverage   98.01%   97.98%   -0.03%     
==========================================
  Files          71       71              
  Lines       10429    10429              
  Branches      936      936              
==========================================
- Hits        10222    10219       -3     
- Misses        166      168       +2     
- Partials       41       42       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@dime10 dime10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/changelog.md on your branch with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@lillian542 lillian542 merged commit 90eac6d into main Jun 21, 2024
41 of 42 checks passed
@lillian542 lillian542 deleted the stop_disabling_new_opmath branch June 21, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants