Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump python version #121

Merged
merged 6 commits into from
Feb 9, 2023
Merged

Bump python version #121

merged 6 commits into from
Feb 9, 2023

Conversation

AlbertMitjans
Copy link
Contributor

@AlbertMitjans AlbertMitjans commented Feb 8, 2023

  • Copy .readthedocs.yaml configuration file from PL to avoid using python3.7 to build the docs.
  • Update tests.yml workflow to stop using python3.7 in integration-tests.
  • Run black.

@AlbertMitjans AlbertMitjans changed the title readthedocs: Add configuration file. Bump python version Feb 8, 2023
@AlbertMitjans AlbertMitjans mentioned this pull request Feb 8, 2023
Copy link
Contributor

@MarquessV MarquessV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think my reviews hold any weight here, but looks good!

@timmysilv
Copy link
Contributor

is this a formal end for 3.7 support for this plugin? if so, can you remove it from setup.py and the README (bump to 3.8 there)? otherwise lgtm!

@AlbertMitjans
Copy link
Contributor Author

if so, can you remove it from setup.py and the README (bump to 3.8 there)?

Good catch! Done 👍

@AlbertMitjans
Copy link
Contributor Author

AlbertMitjans commented Feb 8, 2023

is this a formal end for 3.7 support for this plugin?

Yes! All PL plugins should end 3.7 support

Copy link
Contributor

@timmysilv timmysilv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also now realizing we should add a changelog entry to formalize the end of 3.7 support... please add that and 🚢 🚢 !

@AlbertMitjans AlbertMitjans merged commit c5637ab into master Feb 9, 2023
@AlbertMitjans AlbertMitjans deleted the add-readthedocs-yaml branch February 9, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants