Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin to PL 0.29 #134

Merged
merged 10 commits into from
Apr 18, 2023
Merged

Pin to PL 0.29 #134

merged 10 commits into from
Apr 18, 2023

Conversation

lillian542
Copy link
Contributor

@lillian542 lillian542 commented Apr 10, 2023

Description of the Change:

  • The plugin's setup.py pins to a maximum version of PennyLane 0.29
  • The readme has a callout box announcing that the plugin is no longer supported and compatible with max 0.29. The docs page has a similar callout. (These both seem to draw from the same part of README.rst)

@codecov
Copy link

codecov bot commented Apr 10, 2023

Codecov Report

Merging #134 (87048ec) into master (19285bc) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #134   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          498       498           
=========================================
  Hits           498       498           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lillian542
Copy link
Contributor Author

[sc-35008]

@lillian542 lillian542 marked this pull request as ready for review April 13, 2023 20:42
README.rst Outdated Show resolved Hide resolved
Copy link

@mudit2812 mudit2812 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change 🚀

README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
@timmysilv
Copy link
Contributor

Some extra spots I'd change:

  • The "Dependencies" section of the README should also mention the max version
  • requirements-ci.txt needs a maximum version or else tests will fail once 0.30 is released

README.rst Outdated Show resolved Hide resolved
requirements-ci.txt Outdated Show resolved Hide resolved
requirements-ci.txt Outdated Show resolved Hide resolved
requirements-ci.txt Outdated Show resolved Hide resolved
Co-authored-by: Matthew Silverman <ma.silv11@gmail.com>
@lillian542 lillian542 merged commit 4daf43e into master Apr 18, 2023
@lillian542 lillian542 deleted the pin-pl branch April 18, 2023 20:00
@trbromley trbromley mentioned this pull request May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants