Add deprecation warning to qnn module #1170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1170 +/- ##
=======================================
Coverage 98.12% 98.12%
=======================================
Files 145 145
Lines 10971 10980 +9
=======================================
+ Hits 10765 10774 +9
Misses 206 206
Continue to review full report at Codecov.
|
|
This is a case where I don't understand what's going on with |
co9olguy
requested changes
Mar 26, 2021
There was a problem hiding this comment.
Thanks @trbromley 👍
I left two suggestions, one about the deprecation string (I don't think what you wrote would actually be accepted by interpreter, and also suggesting a shorter form), and one question/idea about testing
co9olguy
approved these changes
Apr 8, 2021
|
@trbromley seems to be working today 🤔 Just needed master to be merged in
|
trbromley
added a commit
that referenced
this pull request
Apr 16, 2021
This reverts commit 816885a.
trbromley
added a commit
that referenced
this pull request
Apr 19, 2021
This reverts commit 816885a.
josh146
pushed a commit
that referenced
this pull request
Apr 19, 2021
josh146
added a commit
that referenced
this pull request
May 6, 2021
* Revert "Add deprecation warning to qnn module (#1170)" This reverts commit 816885a. * Remove Python 3.6 and add 3.9 * Add lazy loading * Add tests * Add to changelog * Mention 3.9 * Update CI * Add to docs * Fix * Fix note * Allow importing of module * Change order * Change back * Update test * Fix * full stop * black * Apply suggestions from code review Co-authored-by: Tom Bromley <49409390+trbromley@users.noreply.github.com> Co-authored-by: Josh Izaac <josh146@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following this PR #1162 and this issue #1101, we would like to prevent the
qnnmodule from being imported with PL because it also causes TF and Torch to be imported. This is a breaking change for users ofKerasLayerandTorchLayer, and we will provide a deprecation warning for one release cycle before making the change.