-
Notifications
You must be signed in to change notification settings - Fork 583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add deprecation warning to qnn module #1170
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1170 +/- ##
=======================================
Coverage 98.12% 98.12%
=======================================
Files 145 145
Lines 10971 10980 +9
=======================================
+ Hits 10765 10774 +9
Misses 206 206
Continue to review full report at Codecov.
|
This is a case where I don't understand what's going on with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @trbromley 👍
I left two suggestions, one about the deprecation string (I don't think what you wrote would actually be accepted by interpreter, and also suggesting a shorter form), and one question/idea about testing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @co9olguy for the suggestions!
@trbromley seems to be working today 🤔 Just needed master to be merged in |
This reverts commit 816885a.
This reverts commit 816885a.
* Revert "Add deprecation warning to qnn module (#1170)" This reverts commit 816885a. * Remove Python 3.6 and add 3.9 * Add lazy loading * Add tests * Add to changelog * Mention 3.9 * Update CI * Add to docs * Fix * Fix note * Allow importing of module * Change order * Change back * Update test * Fix * full stop * black * Apply suggestions from code review Co-authored-by: Tom Bromley <49409390+trbromley@users.noreply.github.com> Co-authored-by: Josh Izaac <josh146@gmail.com>
Following this PR #1162 and this issue #1101, we would like to prevent the
qnn
module from being imported with PL because it also causes TF and Torch to be imported. This is a breaking change for users ofKerasLayer
andTorchLayer
, and we will provide a deprecation warning for one release cycle before making the change.