Minor improvement to CircuitDrawer class interface #1640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Josh Izaac <josh146@gmail.com>
albi3ro
added
code quality 🎓
albi3ro
requested review from
antalszava and
thisac
and removed request for
antalszava
Co-authored-by: Theodor <theodor@xanadu.ai>
thisac
approved these changes
Sep 13, 2021
| self.charset = charset | ||
|
|
||
| if charset is None: | ||
| self.charset = CHARSETS["unicode"]() |
There was a problem hiding this comment.
Is CHARSETS["unicode"]() the same as charsets.UnicodeCharSet?
There was a problem hiding this comment.
An instance of that, yes. Another change in this PR is that we use instances of that class instead of the class itself.
There was a problem hiding this comment.
Another change in this PR is that we use instances of that class instead of the class itself.
Could this change have any downsides or raise potential unexpected issues, e.g. when passing it along to the representation resolver?
There was a problem hiding this comment.
nope. everything is static methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
qml.circuit_drawer.CircuitDrawerclass has a keywordcharsetthat accepts a special classCharSet. Higher-level functions acceptcharsetas a string, either"unicode"or"ascii".graph.draw()has to import theCHARSETSdictionary and convert between a string and aCharSetinstance.Since the
CharSetclass is an internal implementation detail, I'd like to remove it from API to create a circuit drawer. After this PR. creating a circuit drawer class is simpler, because you can just pass it the relevant string, and the class handles the rest.This change simply moves relevant circuit drawing code into the circuit drawing classes.