-
Notifications
You must be signed in to change notification settings - Fork 575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor improvement to CircuitDrawer class interface #1640
Merged
Merged
Changes from 6 commits
Commits
Show all changes
105 commits
Select commit
Hold shift + click to select a range
80d4159
initial commit
albi3ro 54a2fe5
fix mistake
albi3ro e62a42b
add examples
albi3ro b1637d4
Merge branch 'master' into circuitdrawer
albi3ro 6f81cf0
add to docs, change folder name
albi3ro 860f959
Merge branch 'circuitdrawer' of https://github.com/PennyLaneAI/pennyl…
albi3ro d9e7343
trying to get images in documentation
albi3ro 2180823
Merge branch 'master' into circuitdrawer
albi3ro 7137c96
Merge branch 'master' into circuitdrawer
albi3ro e7428f0
remove configuration dictionaries, wires to init
albi3ro 191ab09
add color to all methods
albi3ro 57876da
Add usage details
albi3ro f44a84f
Merge branch 'master' into circuitdrawer
albi3ro f247897
Add tests
albi3ro aaa23e8
Merge branch 'master' into circuitdrawer
albi3ro 3f53fa5
try to fix docstring
albi3ro e90556a
Merge branch 'circuitdrawer' of https://github.com/PennyLaneAI/pennyl…
albi3ro 309b7ed
move to circuit_drawer module, add some tests
albi3ro dbc2435
trying to fix docs
albi3ro d38291d
always generate figures in correct folder
albi3ro 2264df5
more tests
albi3ro 46d19c8
Merge branch 'master' into circuitdrawer
albi3ro 9ff05af
Merge branch 'circuitdrawer' of https://github.com/PennyLaneAI/pennyl…
albi3ro f643bf2
Merge branch 'master' into circuitdrawer
albi3ro 4dda03d
documentation experiment
albi3ro 0b890ec
Merge branch 'circuitdrawer' of https://github.com/PennyLaneAI/pennyl…
albi3ro 596cb51
changelog, black, trying to fix docs
albi3ro 1163497
Merge branch 'master' into circuitdrawer
albi3ro 6d358aa
Update doc/code/qml_circuit_drawer.rst
albi3ro 8eeef97
fix docs hopefully, more tests
albi3ro e263ae7
Merge branch 'master' into circuitdrawer
albi3ro 0f2e15c
oops
albi3ro 51f8842
Apply suggestions from code review
albi3ro 80e1a08
testing some ideas
albi3ro 4febca4
Merge branch 'circuitdrawer' of https://github.com/PennyLaneAI/pennyl…
albi3ro 092afac
fix conflict
albi3ro a38722b
oops
albi3ro 8463cb1
Merge branch 'master' into circuitdrawer
antalszava e85a909
add controlo, some coloring updates
albi3ro 22eaeaa
more color fixing
albi3ro 5b302b7
change formatting syntax
albi3ro bcd60f9
update changelog
albi3ro 7b21fa4
Merge branch 'master' into circuitdrawer
albi3ro 7b9d6f2
Merge branch 'master' into circuitdrawer
albi3ro 1abc8be
Merge branch 'master' into circuitdrawer
albi3ro 7edfa10
Merge branch 'master' into circuitdrawer
albi3ro 497c228
fix images, rcparams example
albi3ro 6196707
Merge branch 'master' into circuitdrawer
albi3ro 059898a
Apply suggestions from code review
albi3ro 0f924e4
documentation updates
albi3ro 5068a33
tests passing with updated version
albi3ro 684ab4b
Merge branch 'master' into circuitdrawer
albi3ro 8edebab
fix tests
albi3ro 3bdfddc
get tests passing
albi3ro e376f75
black
albi3ro 959c092
dict to {}
albi3ro e2cebcc
Merge branch 'master' into circuitdrawer
albi3ro b893243
Merge branch 'master' into circuitdrawer
albi3ro 86a7e0e
docstring change, updated images
albi3ro 12d4c32
images
albi3ro b2a6ffc
getting documentation to build
albi3ro b8869fb
minor doc update
albi3ro 9d48bfe
fix link
albi3ro 5764a92
black
albi3ro 653c384
Apply suggestions from code review
albi3ro 44cdfb0
Merge branch 'master' into circuitdrawer
albi3ro b87b4be
remove partial black frame
albi3ro 2589dbd
Merge branch 'master' into circuitdrawer
albi3ro fc293f2
black
albi3ro 98f349b
Merge branch 'circuitdrawer' of https://github.com/PennyLaneAI/pennyl…
albi3ro 226412d
update tests
albi3ro c4d001e
Merge branch 'master' into circuitdrawer
albi3ro 011e57b
Apply suggestions from code review
albi3ro 62ad323
Merge branch 'master' into circuitdrawer
albi3ro 673a824
change kwargs to options
albi3ro 8490d26
add some spaces
albi3ro 947d58e
move fig, ax, and shape config vars
albi3ro 367177c
Merge branch 'master' into circuitdrawer
albi3ro 1abede9
attributes in the docstring
albi3ro f8fe518
make fig and ax properties
albi3ro 6bd6c6e
minor wording change
albi3ro b153186
minor wording change
albi3ro bea73ba
initial commit
albi3ro 9a231f2
changelog, tests
albi3ro 5413124
black
albi3ro 0ba11a6
Merge branch 'master' into circuit-drawer-charsets
albi3ro df05eff
Merge branch 'master' into circuitdrawer
albi3ro 208b27a
Merge branch 'master' into circuit-drawer-charsets
albi3ro ff6ef31
Apply suggestions from code review
albi3ro cf38411
Merge branch 'master' into circuitdrawer
albi3ro a3fadda
add options for control type gates
albi3ro e51afe5
Merge branch 'master' into circuit-drawer-charsets
albi3ro 472a663
remove zorder from keywords
albi3ro 48a9954
changelog
albi3ro 527d81d
Merge branch 'master' into circuitdrawer
albi3ro 68301a7
code factor
albi3ro 7f905b1
Merge branch 'circuitdrawer' of https://github.com/PennyLaneAI/pennyl…
albi3ro d57abeb
black
albi3ro 2c72c6c
Apply suggestions from code review
albi3ro 77693d5
Merge branch 'circuitdrawer' of https://github.com/PennyLaneAI/pennyl…
albi3ro 60169c5
Merge branch 'master' into circuit-drawer-charsets
albi3ro ab5641e
Merge branch 'circuit-drawer-charsets' of https://github.com/PennyLan…
albi3ro ee87c92
trying to fix some git problem
albi3ro b278baa
fixing git catastrophe
albi3ro 930ef33
git fixing
albi3ro File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is
CHARSETS["unicode"]()
the same ascharsets.UnicodeCharSet
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An instance of that, yes. Another change in this PR is that we use instances of that class instead of the class itself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this change have any downsides or raise potential unexpected issues, e.g. when passing it along to the representation resolver?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nope. everything is static methods.