device suite passes in clean environment #1641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albi3ro
commented
Sep 10, 2021
albi3ro
added
the
review-ready 👌
Codecov Report
@@ Coverage Diff @@
## master #1641 +/- ##
=======================================
Coverage 99.15% 99.15%
=======================================
Files 196 196
Lines 14290 14290
=======================================
Hits 14169 14169
Misses 121 121 Continue to review full report at Codecov.
|
rmoyard
approved these changes
Sep 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The command
make testruns the device suite, but does not pass in a specific shots keyword. This leads to some test failures.This change allows the test suite to execute properly if no
shotskeyword is passed.