Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Jax documentation #1742

Merged
merged 16 commits into from
Oct 12, 2021
Merged

Update Jax documentation #1742

merged 16 commits into from
Oct 12, 2021

Conversation

rmoyard
Copy link
Contributor

@rmoyard rmoyard commented Oct 12, 2021

Context:

Correct some typos found by @ankit27kh

Related GitHub Issues:

Closes #1736

@github-actions
Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@codecov
Copy link

codecov bot commented Oct 12, 2021

Codecov Report

Merging #1742 (7b95549) into master (c3c2e22) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1742   +/-   ##
=======================================
  Coverage   99.21%   99.21%           
=======================================
  Files         204      204           
  Lines       15467    15467           
=======================================
  Hits        15346    15346           
  Misses        121      121           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3c2e22...7b95549. Read the comment docs.

Copy link
Contributor

@antalszava antalszava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 💯 Thanks for fixing this so quickly. 🙂

The warning likely comes from this line, where we work with the np.int64 type:
https://github.com/PennyLaneAI/pennylane/blob/master/pennylane/_qubit_device.py#L541

@rmoyard rmoyard merged commit ce15837 into master Oct 12, 2021
@rmoyard rmoyard deleted the jaxdoc branch October 12, 2021 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Incorrect example in documentation
3 participants