Convert a directed multigraph to tape #2165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ithub.com:PennyLaneAI/pennylane into sc-13390-a-user-can-convert-a-tape-to-an-accurate
…stateprep conversion logic
…ithub.com:PennyLaneAI/pennylane into sc-13390-a-user-can-convert-a-tape-to-an-accurate
Co-authored-by: Tom Bromley <49409390+trbromley@users.noreply.github.com>
Co-authored-by: Tom Bromley <49409390+trbromley@users.noreply.github.com>
…of github.com:PennyLaneAI/pennylane into sc-13394-a-user-can-convert-a-multigraph-to-a-quantum
anthayes92
commented
Feb 10, 2022
|
not sure about the CodeFactor error for the missing docstring in |
trbromley
reviewed
Feb 11, 2022
There was a problem hiding this comment.
Thanks @anthayes92! Looking at the code, I'm not sure the subscript approach is worth the added logic and suggest we consider going back to the original approach.
Co-authored-by: Tom Bromley <49409390+trbromley@users.noreply.github.com>
trbromley
reviewed
Feb 15, 2022
There was a problem hiding this comment.
Thanks @anthayes92! This is looking good, I have a few more comments/suggestions to be resolved but happy to approve once done.
trbromley
approved these changes
Feb 16, 2022
There was a problem hiding this comment.
Approved, although would still like to resolve this comment end potentially remove test_non_unique_node_order unless it is different to test_graph_to_tape. Thanks @anthayes92!
anthayes92
deleted the
sc-13394-a-user-can-convert-a-multigraph-to-a-quantum
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
In the circuit cutting pipeline, once we have the subgraphs corresponding to the circuit fragments we must then to convert these to tapes in order to execute them.
Description of the Change:
A method for converting directed multigraphs to tapes has been added.
Benefits:
Facilitates circuit cutting.