Raise a deprecation warning if Operator.decomposition is a staticmethod
#2214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. You may have forgotten to update the changelog!
|
Codecov Report
@@ Coverage Diff @@
## master #2214 +/- ##
==========================================
+ Coverage 96.52% 99.26% +2.74%
==========================================
Files 231 231
Lines 18191 18197 +6
==========================================
+ Hits 17558 18063 +505
+ Misses 633 134 -499
Continue to review full report at Codecov.
|
mariaschuld
reviewed
Feb 22, 2022
| "Either define the static method 'compute_decomposition' instead, or use " | ||
| "'self.wires' and 'self.parameters'.", | ||
| UserWarning, | ||
| ) |
mariaschuld
reviewed
Feb 22, 2022
|
Thanks @mariaschuld! This requires the fix in #2218 for the tests to pass :) |
|
True, but I also meant the code coverage...good to test the fix? |
mariaschuld
reviewed
Feb 22, 2022
| def decomposition(*params, wires): | ||
| qml.RY(params[0], wires=wires[0]) | ||
| qml.PauliZ(wires=wires[0]) | ||
| qml.RX(params[1], wires=wires[0]) |
There was a problem hiding this comment.
I think we just need another case with no params here...
There was a problem hiding this comment.
oh oops, I didn't even spot this
mariaschuld
approved these changes
Feb 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: As part of the recent operator refactor, the static method
Operator.decompositionwas renamed toOperator.compute_decomposition. The newOperator.decompositionis now an instance method.Description of the Change: Adds a deprecation warning to alert developers to this change.
Benefits: As above.
Possible Drawbacks: n/a
Related GitHub Issues: Closes #2210