Introduce operator input parameter ndim_params and batch_size attributes
#2575
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2575 +/- ##
=======================================
Coverage 99.58% 99.58%
=======================================
Files 243 243
Lines 19589 19641 +52
=======================================
+ Hits 19508 19560 +52
Misses 81 81
Continue to review full report at Codecov.
|
|
[sc-19788] |
dwierichs
changed the title
ndim_params and batch_size attributesndim_params and batch_size attributes
dwierichs
changed the title
ndim_params and batch_size attributesndim_params and batch_size attributes
There was a problem hiding this comment.
Thanks @dwierichs! Wow, this is a really clean PR, very nice! I left some comments and questions, but all minor - I think the main components of the PR are in very good shape
Co-authored-by: Josh Izaac <josh146@gmail.com>
There was a problem hiding this comment.
Nice work @dwierichs! Happy for this to be merged when my suggestions are resolved :)
Co-authored-by: Josh Izaac <josh146@gmail.com>
|
@josh146 Thanks for the second review! There are 2 open conversations that should not require any additional action, I think. |
|
[sc-19788] |
|
Resolved :) |
This PR implements the first part of parameter broadcasting, including the operator attributes
ndim_paramsandbatch_size(which is based on_batch_size) as well as the tape attributebatch_sizewhich is inferred from the batch sizes of the tape operations.These attributes will be used to determine if an operator or a tape is batched, which will be used by devices at execution.