Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding batching support for symbolic operators #2672

Merged
merged 4 commits into from
Jun 7, 2022
Merged

Conversation

albi3ro
Copy link
Contributor

@albi3ro albi3ro commented Jun 7, 2022

This PR updates the Adjoint and Pow symbolic operators to also have the new ndim_params and batch_size properties added recently in #2575. It also adds the is_hermitian property to the Adjoint symbolic operator.

This PR should fix the failing build for the tutorial_classical_kernels.py demo.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2022

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@albi3ro albi3ro requested review from dwierichs and rmoyard June 7, 2022 17:00
@codecov
Copy link

codecov bot commented Jun 7, 2022

Codecov Report

Merging #2672 (b857693) into master (a4a6fda) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2672   +/-   ##
=======================================
  Coverage   99.58%   99.58%           
=======================================
  Files         249      249           
  Lines       20185    20200   +15     
=======================================
+ Hits        20102    20117   +15     
  Misses         83       83           
Impacted Files Coverage Δ
pennylane/ops/op_math/adjoint_class.py 100.00% <100.00%> (ø)
pennylane/ops/op_math/pow_class.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4a6fda...b857693. Read the comment docs.

Copy link
Contributor

@rmoyard rmoyard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @albi3ro for the quick change, it looks good to me 💯

@albi3ro albi3ro merged commit d539835 into master Jun 7, 2022
@albi3ro albi3ro deleted the op_math-batching branch June 7, 2022 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants