Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DefaultPulse device #3638

Closed
wants to merge 5 commits into from
Closed

Add DefaultPulse device #3638

wants to merge 5 commits into from

Conversation

lillian542
Copy link
Contributor

@lillian542 lillian542 commented Jan 16, 2023 •
edited
Loading

Set up dummy device (currently default.qubit with addition of dt, dim and drift attributes) as first step in a device to support pulse programming

@lillian542 lillian542 marked this pull request as ready for review January 16, 2023 14:48
@github-actions
Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@lillian542
Copy link
Contributor Author

[sc-31947]

Qottmann
Qottmann approved these changes Jan 16, 2023
View reviewed changes
Copy link
Contributor

@Qottmann Qottmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @lillian542 💯

@lillian542 lillian542 changed the title Add DefualtPulse device Add DefaultPulse device Jan 16, 2023
trbromley
trbromley reviewed Jan 17, 2023
View reviewed changes
pennylane/devices/default_pulse.py
Comment on lines +36 to +37
dim (int): dimensions of the system (2 for qubits, 3 for qutrits, etc)
drift(Operator): optional Hamiltonian term representing a constant drift term for the system Hamiltonian
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we perhaps omit these terms for now, until we're ready to use them?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be also nice to raise a warning when drift is not None, saying that this currently does nothing

@lillian542
Copy link
Contributor Author

[sc-31947]

@Qottmann
Copy link
Contributor

Just fyi, @trbromley and I discussed today that for the v0.29.0 we would actually not promote using default.pulse. this is mainly because it is still unclear whether providing the option for an omnipresent drift term makes sense or not. This device will be relevant however as soon as we move towards qutrits / qudtis. If its already ready to merge, we can do that, else I would put it on the backlog for the moment.

@AlbertMitjans AlbertMitjans removed their request for review February 6, 2023 16:27
@lillian542
Copy link
Contributor Author

will use default.qubit.jax instead

@lillian542 lillian542 closed this Apr 27, 2023
@trbromley trbromley deleted the pulse-device branch March 7, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlbertMitjans AlbertMitjans AlbertMitjans left review comments

@trbromley trbromley trbromley left review comments

@Qottmann Qottmann Qottmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lillian542 @Qottmann @AlbertMitjans @trbromley