-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
convert_to_numpy_parameters
uses bind_new_parameters
#4540
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #4540 +/- ##
==========================================
- Coverage 99.66% 99.65% -0.01%
==========================================
Files 376 376
Lines 33102 33103 +1
==========================================
- Hits 32992 32990 -2
- Misses 110 113 +3
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just one question, but it's non-blocking
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
once you add a test to please codecov for that one line, lgtm!
[sc-25029] Fixes #2987
convert_to_numpy_parameters
was created beforebind_new_parameters
, so it was still using the old way ofop.data = new_data
.