Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert_to_numpy_parameters uses bind_new_parameters #4540

Merged
merged 10 commits into from
Aug 31, 2023

Conversation

albi3ro
Copy link
Contributor

@albi3ro albi3ro commented Aug 29, 2023

[sc-25029] Fixes #2987

convert_to_numpy_parameters was created before bind_new_parameters, so it was still using the old way of op.data = new_data.

@albi3ro albi3ro marked this pull request as ready for review August 29, 2023 15:55
@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01% ⚠️

Comparison is base (6fae4e7) 99.66% compared to head (dcdfea0) 99.65%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4540      +/-   ##
==========================================
- Coverage   99.66%   99.65%   -0.01%     
==========================================
  Files         376      376              
  Lines       33102    33103       +1     
==========================================
- Hits        32992    32990       -2     
- Misses        110      113       +3     
Files Changed Coverage Δ
pennylane/ops/functions/bind_new_parameters.py 100.00% <100.00%> (ø)
...ennylane/transforms/convert_to_numpy_parameters.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@albi3ro albi3ro requested a review from a team August 30, 2023 14:19
Copy link
Contributor

@mudit2812 mudit2812 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just one question, but it's non-blocking

Copy link
Contributor

@timmysilv timmysilv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

once you add a test to please codecov for that one line, lgtm!

@albi3ro albi3ro enabled auto-merge (squash) August 31, 2023 20:53
@albi3ro albi3ro merged commit 930c558 into master Aug 31, 2023
39 checks passed
@albi3ro albi3ro deleted the convert-to-numpy-use-bind branch August 31, 2023 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] pennylane.tape.Unwarp does not unwrap Hamiltonian coefficients
3 participants