-
Notifications
You must be signed in to change notification settings - Fork 585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate prep kwarg and remove third list from process_queue #4554
Conversation
[sc-43884] |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #4554 +/- ##
=======================================
Coverage 99.66% 99.66%
=======================================
Files 376 376
Lines 33070 33071 +1
=======================================
+ Hits 32960 32961 +1
Misses 110 110
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please uncomment this pytest.warns
and indent the line below it to catch this warning. One extra comment in-line, otherwise looks good!
The empty third list returned by
process_queue
is removed, and a deprecation warning is added when theprep
kwarg is used inQuantumScript