Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate prep kwarg and remove third list from process_queue #4554

Merged
merged 9 commits into from
Aug 30, 2023

Conversation

lillian542
Copy link
Contributor

@lillian542 lillian542 commented Aug 29, 2023

The empty third list returned by process_queue is removed, and a deprecation warning is added when the prep kwarg is used in QuantumScript

@lillian542
Copy link
Contributor Author

[sc-43884]

@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (90f09d4) 99.66% compared to head (de4aa54) 99.66%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4554   +/-   ##
=======================================
  Coverage   99.66%   99.66%           
=======================================
  Files         376      376           
  Lines       33070    33071    +1     
=======================================
+ Hits        32960    32961    +1     
  Misses        110      110           
Files Changed Coverage Δ
pennylane/queuing.py 100.00% <100.00%> (ø)
pennylane/tape/operation_recorder.py 96.77% <100.00%> (ø)
pennylane/tape/qscript.py 100.00% <100.00%> (ø)
pennylane/tape/tape.py 98.55% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lillian542 lillian542 requested a review from a team August 30, 2023 13:50
@lillian542 lillian542 requested a review from a team August 30, 2023 14:20
Copy link
Contributor

@timmysilv timmysilv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please uncomment this pytest.warns and indent the line below it to catch this warning. One extra comment in-line, otherwise looks good!

pennylane/queuing.py Show resolved Hide resolved
@lillian542 lillian542 enabled auto-merge (squash) August 30, 2023 16:05
@lillian542 lillian542 merged commit 2e3c671 into master Aug 30, 2023
39 checks passed
@lillian542 lillian542 deleted the deprecate_prep_kwarg branch August 30, 2023 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants