Update shot_adaptive to not mutate device shots #4599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. You may have forgotten to update the changelog!
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #4599 +/- ##
==========================================
- Coverage 99.64% 99.64% -0.01%
==========================================
Files 375 375
Lines 33358 33342 -16
==========================================
- Hits 33239 33222 -17
- Misses 119 120 +1
☔ View full report in Codecov by Sentry. |
|
[sc-44399] |
mudit2812
approved these changes
Sep 18, 2023
timmysilv
changed the title
mudit2812
pushed a commit
that referenced
this pull request
Sep 19, 2023
**Context:**
`shot_adaptive.py` would change device wires, run a QNode with the
device, then change the wires back. We can just run the QNode with
different shots without changing the device!
**Description of the Change:**
Instead of changing device shots, pass `shots=new_shots` as a kwarg to
any QNode execution.
I also removed a silly test for something hacky that users probably
should not even be able to do... it's not that hard to add
`@qml.qnode(qml.device("default.qubit", shots=1000))` to the top of any
function : )
**Benefits:**
- It will work on the new device API without any changes (I ran the
tests locally with DQ2, worked perfectly)
- No more unnecessary try-finally blocks
- Not mutating object properties is always cool and wise
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
shot_adaptive.pywould change device wires, run a QNode with the device, then change the wires back. We can just run the QNode with different shots without changing the device!Description of the Change:
Instead of changing device shots, pass
shots=new_shotsas a kwarg to any QNode execution.I also removed a silly test for something hacky that users probably should not even be able to do... it's not that hard to add
@qml.qnode(qml.device("default.qubit", shots=1000))to the top of any function : )Benefits: