Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draw support QJIT qnodes #4609

Merged
merged 13 commits into from
Sep 22, 2023
Merged

Draw support QJIT qnodes #4609

merged 13 commits into from
Sep 22, 2023

Conversation

rmoyard
Copy link
Contributor

@rmoyard rmoyard commented Sep 18, 2023

Context:

Catalyst users cannot draw a circuit.

Description of the Change:

  • Add drawing capacities in PennyLane for Catalyst
  • The ZX test suite is changed to external libraries test suite.

Benefits:

Catalyst users can draw QJIT circuits.

@github-actions
Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (a05babb) 99.63% compared to head (29cce9f) 99.63%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4609   +/-   ##
=======================================
  Coverage   99.63%   99.63%           
=======================================
  Files         375      375           
  Lines       33547    33556    +9     
=======================================
+ Hits        33423    33432    +9     
  Misses        124      124           
Files Changed Coverage Δ
pennylane/drawer/draw.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mudit2812 mudit2812 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Can you add an entry to the improvements section of the changelog? I'm ready to approve otherwise.

@dime10
Copy link
Contributor

dime10 commented Sep 21, 2023

[sc-41308]

Copy link
Member

@maliasadi maliasadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rmoyard! I'll approve after merging the suggestion and checking tests 🎉

pennylane/drawer/draw.py Outdated Show resolved Hide resolved
pennylane/drawer/draw.py Show resolved Hide resolved
rmoyard and others added 2 commits September 21, 2023 10:31
Co-authored-by: Ali Asadi <ali@xanadu.ai>
pennylane/drawer/draw.py Outdated Show resolved Hide resolved
@trbromley trbromley merged commit b7279db into master Sep 22, 2023
39 checks passed
@trbromley trbromley deleted the draw_catalyst_support branch September 22, 2023 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants