remove _qfunc_output from tape #4651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. You may have forgotten to update the changelog!
|
|
[sc-36827] |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4651 +/- ##
==========================================
- Coverage 99.63% 99.63% -0.01%
==========================================
Files 376 376
Lines 33666 33647 -19
==========================================
- Hits 33542 33523 -19
Misses 124 124
☔ View full report in Codecov by Sentry. |
timmysilv
commented
Oct 6, 2023
albi3ro
reviewed
Oct 6, 2023
lillian542
approved these changes
Oct 6, 2023
albi3ro
approved these changes
Oct 6, 2023
PietropaoloFrisoni
added a commit
that referenced
this pull request
Aug 28, 2024
#6153) **Context:** In #4651, `tape._qfunc_output` was removed. As a consequence, for `qml.pattern_matching_optimization`, the original quantum function output (used to re-create the quantum function output of the new tape) was removed. Since in the optimization process of `qml.pattern_matching_optimization` the measurements of the original tape are not involved, the measurements of the tape coming out from the optimization process correspond to an empty list, causing information on such a variable to be lost in the optimization process. **Description of the Change:** We simply store the original measurements and assign them to the new (optimized) tape, similarly to the original approach (see #2032). **Benefits:** Measurements are preserved in the optimization process. **Possible Drawbacks:** I can think of none since measurements should not be involved in the optimization process. **Related GitHub Issues:** #6088 **Related Shortcut Stories** [sc-71174] --------- Co-authored-by: Christina Lee <christina@xanadu.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
_qfunc_outputis a pain to keep track of, and we only need it for QNode handling.QNode._qfunc_outputstill exists, buttape._qfunc_outputdoes not.Description of the Change:
tape._qfunc_outputmake_qscriptso it can get the tape result shapeparam_shift_cv(the only other place that usedtape._qfunc_output) because it doesn't accept parameter broadcasting, shot vectors, or multiple measurements, so it really never needs ittype(tape)so QuantumScript in = QuantumScript outBenefits:
everyone hates
tape._qfunc_outputso this should bring peace of mind. less work, one less private attribute being used publicly.Possible Drawbacks:
Maybe harder to see the output shape of a tape?
tape.measurementsshould mostly make it clear.