-
Notifications
You must be signed in to change notification settings - Fork 585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CosineWindow
StatePrep
#4683
CosineWindow
StatePrep
#4683
Conversation
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4683 +/- ##
=========================================
Coverage ? 99.64%
=========================================
Files ? 381
Lines ? 34052
Branches ? 0
=========================================
Hits ? 33930
Misses ? 122
Partials ? 0
☔ View full report in Codecov by Sentry. |
[sc-45845] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @KetpuntoG! left some comments and suggestions.
Co-authored-by: soranjh <40344468+soranjh@users.noreply.github.com>
Co-authored-by: soranjh <40344468+soranjh@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @KetpuntoG, will approve when my minor comments are addressed.
Co-authored-by: soranjh <40344468+soranjh@users.noreply.github.com>
Co-authored-by: soranjh <40344468+soranjh@users.noreply.github.com>
Co-authored-by: soranjh <40344468+soranjh@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 💯! I added a few small comments to improve the look of the docs, but otherwise good work!
Co-authored-by: Jay Soni <jbsoni@uwaterloo.ca>
Co-authored-by: Jay Soni <jbsoni@uwaterloo.ca>
@mudit2812 ready to merge 🚀 |
Creation of the cosine window, a state whose vector is equivalent to the cosine function:
notes to the reviewer
Instead of the template mentioned in the PRD:
This other one has been used:
![Captura de pantalla 2023-10-18 a las 9 13 06](https://private-user-images.githubusercontent.com/65235481/276258869-0c6f96d8-a00f-4a33-a3a8-e0101c4467fb.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjU5OTUxNTIsIm5iZiI6MTcyNTk5NDg1MiwicGF0aCI6Ii82NTIzNTQ4MS8yNzYyNTg4NjktMGM2Zjk2ZDgtYTAwZi00YTMzLWEzYTgtZTAxMDFjNDQ2N2ZiLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MTAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTEwVDE5MDA1MlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWJiMzYzN2ZmYzQxMjFmNTdhZTYzNzMxYjNiYWU5NmUxYzg4MmM1NzJlNDE5NTUzZGNmZjZkOTljM2Y0NzY1YzAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.o31BM0O7CNQ45EYA1-hVOf_hZB0eFzzGmC3-25-gNuQ)
This is because in the paper from which it was extracted, it worked with basic states from$-|N/2\rangle$ to $|N/2-1\rangle$ and we work with states from $|0\rangle$ to $|N-1\rangle$ . so I have made some adjustments to the rotations to adapt it.