split-non-commuting use wire grouping with non-pauli-word observable
#5827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5827 +/- ##
==========================================
- Coverage 99.66% 99.66% -0.01%
==========================================
Files 415 415
Lines 39802 39506 -296
==========================================
- Hits 39670 39373 -297
- Misses 132 133 +1 ☔ View full report in Codecov by Sentry. |
albi3ro
reviewed
Jun 10, 2024
There was a problem hiding this comment.
Love how simple this fix is :)
Just a couple questions on testing. Since default.qubit itself can handle measuring projectors with no issue, we should probably also unit test the transform for qscript in, batch out.
Let's also add some tests with hadamards/ products of hadamards.
…o split-non-com-non-pauli
albi3ro
reviewed
Jun 10, 2024
Co-authored-by: Christina Lee <christina@xanadu.ai>
Oooops |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
The new unified
split_non_commutingusesqwcgrouping by default, but it is not supported for non-pauli-word observables.Description of the Change:
Use wire-based grouping if one of the observables is not a pauli word
Related GitHub Issues:
Fixes #4362
[sc-42003]