[LDAP] Improvement (Reopen) #245
Open
+72
−182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XiaoliChan
requested review from
zblurx,
Marshall-Hallenbeck,
NeffIsBack and
mpgn
as code owners
XiaoliChan
force-pushed
the
ldap-baseOnDNS
branch
from
43e7117
to
613ecac
Compare
Signed-off-by: XiaoliChan <30458572+XiaoliChan@users.noreply.github.com>
|
Conflicts need to be resolved before we can merge in the main branch and get the branch into a reviewable state :) |
|
@NeffIsBack Sorry for the late response, the |
|
@XiaoliChan no worries, just marked the PR so i know its not ready for a review. Take your time! |
Signed-off-by: XiaoliChan <30458572+XiaoliChan@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog:
--ldap-timeoutgcThis PR is base on #196