Update dependencies (including impacket fork) for v1.1.0 #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marshall-Hallenbeck
requested review from
zblurx and
NeffIsBack
as code owners
… replace flake8 with ruff, and remove black
…nyw0rth/NetExec into marshall-dependency-update-9-19-2023
|
Won't be updating dependencies for v1, but the release after, so v1 is as stable as possible. |
NeffIsBack
changed the title
|
This still needs a few more things added to it. |
Signed-off-by: Marshall Hallenbeck <Marshall.Hallenbeck@gmail.com>
|
@NeffIsBack this is good for review |
Tested some basic stuff, seems to work |
|
Also working on a fresh kali install |
NeffIsBack
approved these changes
Oct 15, 2023
There was a problem hiding this comment.
LGTM 👍 @Marshall-Hallenbeck maybe running the tests once would be good, didn't do that. Common commands work tho
NeffIsBack
added
tested
reviewed code
NeffIsBack
approved these changes
Oct 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran the e2e tests, so hopefully it works for everything. A couple dependencies were held back since they caused issues.