Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: hash_spider Lsassy Parser syntax #308

Merged
merged 3 commits into from
May 17, 2024

Conversation

Marshall-Hallenbeck
Copy link
Collaborator

@Marshall-Hallenbeck Marshall-Hallenbeck commented May 17, 2024

hash_spider errors out since Lsassy changed it's Parser class init params here: login-securite/lsassy@9fffbdf

This fixes it to pass in the host, and also adds the DB created during running tests

Error on top, then my fix implemented and re-ran:
image

@Marshall-Hallenbeck Marshall-Hallenbeck added the bug-fix This Pull Request fixes a bug label May 17, 2024
@Marshall-Hallenbeck Marshall-Hallenbeck self-assigned this May 17, 2024
@NeffIsBack
Copy link
Contributor

The logging is a bit messed up lol, gonna fix that real quick

Copy link
Contributor

@NeffIsBack NeffIsBack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now:
image

@Marshall-Hallenbeck Marshall-Hallenbeck merged commit aa9b044 into main May 17, 2024
6 checks passed
@Marshall-Hallenbeck Marshall-Hallenbeck deleted the marshall-hash-spider-fix branch May 17, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix This Pull Request fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants