Improve testing suite #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NeffIsBack
requested review from
zblurx,
Marshall-Hallenbeck and
mpgn
as code owners
mpgn
previously approved these changes
May 20, 2024
Marshall-Hallenbeck
previously approved these changes
May 20, 2024
…stringify it for output
Marshall-Hallenbeck
previously approved these changes
May 21, 2024
…er logic, add put/get file tests for smb, and fix file referencing in tests
Gonna wait until #225 is merged so we don't have merge conflicts again |
Signed-off-by: Marshall Hallenbeck <Marshall.Hallenbeck@gmail.com>
|
@NeffIsBack I fixed the conflicts in the e2e tests and removed the -h test for each protocol since I think its unnecessary, but I kept the overall -h just so we're making sure the argparse is working |
Marshall-Hallenbeck
previously approved these changes
May 24, 2024
mpgn
approved these changes
May 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What have been done:
bh__owned.pymodule as it is redundant now and throws errors.--optionsas it technically doesn't add any testing value (just printing a string)cwdfrom the opened subprocess--print-failuresdefaults to true now as i find that very very useful